A suggested text about a push stream after a CANCEL_PUSH #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| has already received a corresponding push stream. If a push stream arrives | ||
| after a client has sent CANCEL_PUSH, this MAY be treated as a stream error of | ||
| type H3_STREAM_CREATION_ERROR. | ||
| has already received a corresponding push stream. A push stream may arrive |
There was a problem hiding this comment.
Suggested change
| has already received a corresponding push stream. A push stream may arrive | |
| has already received a corresponding push stream. A push stream could arrive |
martinthomson
added
-http
editorial
|
This overlaps the change in #3700. I've cherry-picked it into that branch and we'll address them together. I believe that will also address @martinthomson's comment, since #3700 already discusses the server side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this while reading the draft. I think the text is a bit misleading. The current test suggests that this is a server error, but it may not be a server error:
This PR is just a propose text that make this more clear and changes the error code.